Fix a runtime fault for Windows IOCP w/ memtrack messages. #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the runtime is compiled with `-DUSE_MEMTRACK_MESSAGES` on Windows, the code path for asynchronous I/O events wasn't initializing the pony context prior to its first use, which would likely cause a runtime crash or other undesirable behavior. The `-DUSE_MEMTRACK_MESSAGES` feature is rarely used, and has perhaps never been used on Windows, so that explains why we haven't had a crash reported for this code path. Now that path has been fixed by rearranging the order of the code.
jemc
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ergl
approved these changes
Apr 11, 2022
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the runtime is compiled with
-DUSE_MEMTRACK_MESSAGESonWindows, the code path for asynchronous I/O events wasn't
initializing the pony context prior to its first use,
which would likely cause a runtime crash or other undesirable
behavior.
The
-DUSE_MEMTRACK_MESSAGESfeature is rarely used, and hasperhaps never been used on Windows, so that explains why
we haven't had a crash reported for this code path.
Now that path has been fixed by rearranging the order of the code.
See this Zulip thread for additional discussion.