Disable incorrect runtime assert for ASIO thread shutdown. #4122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutting down the ASIO thread and destroying its message queue,
it is possible that there may be some message(s) in flight to it,
meaning that even though we drained the queue before destroying,
the queue may be non-empty by the time we get to destroying it.
Hence, we cannot reliably assert that the queue is non-empty.
However, for actors, we can proved definitively that an actor
is done receiving messages before we destroy its message queue,
so we want to retain the runtime assert for the actor case.
This change updates the assert to be conditional based on
a boolean parameter to the
ponyint_messageq_destroy
function.For more context, see this Zulip thread.