-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure reachability of types returned by FFI calls #4149
Conversation
After introducing #4060, we forgot to re-add the code that ensured that, if a FFI function call specified different return types, those types were being marked as reachable. This created a situation where programs that introduced a new type (for example, a bare lambda) in the context of a FFI return type would crash the compiler. This was due to having missing information about the type during code generation.
Hi @ergl, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with nit about spacing in the additional.c
6325475
to
852a719
Compare
852a719
to
4f64cc5
Compare
This is now ready to merge (I forgot one spacing change in my last revision). When this is merged, please use the description in the OP as the commit message. |
After introducing #4060, we forgot to re-add the code that ensured that, if a
FFI function call specified different return types, those types were being
marked as reachable.
This created a situation where programs that introduced a new type (for example,
a bare lambda) in the context of a FFI return type would crash the compiler.
This was due to having missing information about the type during code
generation.