Fix incorrect atomics usage #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
|
@jemc this almost assuredly will fix some potential runtime instability/boom/o no, invariant violated issues on Arm. I think that is worth release notes, but I wanted to ask you first. |
SeanTAllen
force-pushed
the
incorrect-atomics
branch
from
cbb2eb3 to
58ab6e7
Compare
I was looking at #1206 and noticed that when Benoit did the porting, that in a few places, he changed the atomics usage unintentionally from what it was previously. This commit reverts those (almost assuredly) inadvertent changes. I can't guarantee that there are no other bits that were incorrect in that commit, but I know these bits where. I believe from a cursory glance that these could do "very bad things" on weakly ordered memory platforms like Arm.
|
Given that this fixes a real-world class of bugs on ARM, I do think it makes sense to add release notes. |
jemc
approved these changes
Jul 19, 2022
|
@jemc can you give the release notes a review and if good, squash and merge this using the first comment on the PR as the commit message? |
ponylang-main
added
the
discuss during sync
Closed
|
@ponylang/committer can someone give this a final review? |
ponylang-main
removed
the
discuss during sync
SeanTAllen
added
the
changelog - fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at #1206 and noticed
that when Benoit did the porting, that in a few places, he changed the
atomics usage unintentionally from what it was previously.
This commit reverts those (almost assuredly) inadvertent changes.
I can't guarantee that there are no other bits that were incorrect
in that commit, but I know these bits where.
I believe from a cursory glance that these could do "very bad things"
on weakly ordered memory platforms like Arm.