Fix broken readline package #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
|
Windows failure is unrelated. We are back to the "it times out" problem again. |
With the release of 0.49.0, we changed `Ansi.erase` to be erasing left rather than right. This made sense based on the comment on the `Ansi.erase` method. However, the actual usage in the standard library of `Ansi.erase` was expecting it to erase to the right. Because of this change, since 0.49.0, the readline support in the `term` package has been broken. This commit switches erase back to erasing to the right and in the process fixes the readline package. The commment on `erase` has been updated to reflect what it actually does. Supporting erasing to both the left and the right seems valuable but, I'm not addressing that here and instead am leaving that to an RFC.
SeanTAllen
force-pushed
the
ansi-erase
branch
from
587ff06 to
de179b4
Compare
jemc
approved these changes
Oct 25, 2022
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of 0.49.0, we changed
Ansi.eraseto be erasing left rather than right. This made sense based on the comment on theAnsi.erasemethod. However, the actual usage in the standard library ofAnsi.erasewas expecting it to erase to the right. Because of this change, since 0.49.0, the readline support in thetermpackage has been broken.This commit switches erase back to erasing to the right and in the process fixes the readline package. The commment on
erasehas been updated to reflect what it actually does.Supporting erasing to both the left and the right seems valuable but, I'm not addressing that here and instead am leaving that to an RFC.