Fix runtime segfault #4294
Merged
Fix runtime segfault #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
chalcolith
approved these changes
Jan 4, 2023
SeanTAllen
force-pushed
the
issue-4284
branch
3 times, most recently
from
b38c69c to
474fb3c
Compare
jemc
approved these changes
Jan 4, 2023
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I implemented turning off the unsafe "don't trace immutable objects" optimization in PR #4256, I incorrectly caused opaque objects to be traced in a couple of scenarios.
Tracing opaque objects will result in a segfault like the one discovered by Gordon.
Fixes #4284