Only use -isystem for LLVM if the directory is not already on the path #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on Arch Linux, using gcc 6.1.1 and LLVM 3.7.1, fails with the error: /usr/include/c++/6.1.1/cmath:45:23: fatal error: math.h: No such file or directory #include_next <math.h> Avoiding the use of -isystem if the LLVM include directory is already on the search path should avoid the problem. This fixes ponylang#797
|
The one CI error looks unrelated, but I'm running that matrix item again to be sure. |
|
Looks good. Nice work @tmmcguire. @jemc you good with merging? |
Praetonus
pushed a commit
to Praetonus/ponyc
that referenced
this pull request
May 13, 2016
The fix introduced in ponylang#824 added a stray slash in the build commands when llvm.include was empty, which caused build failures.
sylvanc
pushed a commit
that referenced
this pull request
May 13, 2016
The fix introduced in #824 added a stray slash in the build commands when llvm.include was empty, which caused build failures.
winksaville
added a commit
to winksaville/ponyc
that referenced
this pull request
Feb 21, 2019
The add lines are from PR ponylang#824 which were changed in ponylang#2976.
winksaville
added a commit
to winksaville/ponyc
that referenced
this pull request
Feb 21, 2019
This fixes ponylang#3016 by adding lines back introduced in PR ponylang#824. This code conditionally added llvm include directory only if it wasn't already included. These lines were a small part of PR ponylang#2976 which adds LLVM 7.0.1 compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on Arch Linux, using gcc 6.1.1 and LLVM 3.7.1, fails with
the error:
/usr/include/c++/6.1.1/cmath:45:23: fatal error: math.h: No such file or directory
#include_next <math.h>
Avoiding the use of -isystem if the LLVM include directory is already
on the search path should avoid the problem.
This fixes #797