This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Allow garbage collection in property tests #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfelsche
reviewed
Jan 4, 2018
ponycheck/property.pony
Outdated
| complete() | ||
| return | ||
| end | ||
| (var sample, _shrinker) = _prop1.gen().generate_and_shrink(_rnd) |
There was a problem hiding this comment.
the gen() method should only be called once to create the constructor. I'd suggest doing it in the constructor and assign it to a field.
| fun ref fail() => | ||
| _h.complete(false) | ||
|
|
||
| class _EmptyIterator[T] |
There was a problem hiding this comment.
We need this as part of itertools in the pony stdlib :)
|
Yeah! And thanks for silently fixing all the accidents in the codebase. |
mfelsche
added a commit
that referenced
this pull request
Jan 6, 2018
This was referenced Jan 6, 2018
Merged
Theodus
pushed a commit
that referenced
this pull request
Jan 6, 2018
Properties do not need to import everything property.pony needed because of this ponyc bug: ponylang/ponyc#2150 anymore, due to the great work on #32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #31 by performing property tests on generated samples and shrinking in separate, recursive actor behaviors. API changes are that
ForAllrequires aGenerator valas an argument and theProperty1UnitTestclass has been added to implement theUnitTesttrait. Examples in the documentation and the examples directory have been updated.