improve regex match of json field in init script #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications to the Cloudsmith API have resulted in mangled version identifiers for the initial ponyup install. This has resulted in the `"tags": {"version": ["latest"]},` being matched as the version, resulting in the following output for `ponyup show`:
```
ponyup-release-[latest]}-x86_64-linux
```
The updated regex should be sufficient to prevent such an issue from occurring in the future without requiring `jq` to be available on the user's system.
SeanTAllen
added a commit
that referenced
this pull request
Aug 22, 2020
SeanTAllen
added a commit
that referenced
this pull request
Aug 22, 2020
Theodus
added a commit
that referenced
this pull request
Aug 22, 2020
Theodus
added a commit
that referenced
this pull request
Aug 22, 2020
Co-authored-by: Theo Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to the Cloudsmith API have resulted in mangled version identifiers for the initial ponyup install. This has resulted in the
"tags": {"version": ["latest"]},being matched as the version, resulting in the following output forponyup show:The updated regex should be sufficient to prevent such an issue from occurring in the future without requiring
jqto be available on the user's system.