Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt for libc type when not on Linux #179

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

SeanTAllen
Copy link
Member

Currently, Darwin users are prompted for the libc type. This shouldn't
be happening. Only Linux users should get prompted.

Closes #178

@SeanTAllen SeanTAllen requested a review from Theodus March 19, 2021 00:09
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Mar 19, 2021
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 179.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen force-pushed the libc-prompt branch 2 times, most recently from ad785ab to fdc4ad1 Compare March 19, 2021 00:16
Copy link
Contributor

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! Just one suggested fix for an existing typo.

ponyup-init.sh Outdated Show resolved Hide resolved
Currently, Darwin users are prompted for the libc type. This shouldn't
be happening. Only Linux users should get prompted.

Closes #178
Copy link
Contributor

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeanTAllen SeanTAllen merged commit b0d8ba5 into main Mar 19, 2021
@SeanTAllen SeanTAllen deleted the libc-prompt branch March 19, 2021 00:43
github-actions bot pushed a commit that referenced this pull request Mar 19, 2021
github-actions bot pushed a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation on macOS 10.15 fails with "Unable to determine libc type"
3 participants