Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for overriding how trigger release announcement step gets version information #23

Merged
merged 2 commits into from
Aug 30, 2020

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Aug 29, 2020

Prior to this commit, the trigger release announcement step
gets the version from GITHUB_REF. For this to work, the step
has to be triggered by a tag being pushed.

This is good for most use-cases, but not all. For example, ponyc
build assets for release on cirrus-ci not github actions. This
means that we want to trigger a release announcement once we've
been notified assets have been uploaded to cloudsmith.

This will not work with trigger release announcement as it can't
get the version from GITHUB_REF as it isn't available there.

This commit adds the ability to provide an optional environment
variable VERSION to the trigger-release-announcement step. If the
variable is set, the version will be taken from that rather than
trying to parse it out of GITHUB_REF.

Closes #22

…on information

Prior to this commit, the trigger release announcement step
gets the version from GITHUB_REF. For this to work, the step
has to be triggered by a tag being pushed.

This is good for most use-cases, but not all. For example, ponyc
build assets for release on cirrus-ci not github actions. This
means that we want to trigger a release announcement once we've
been notified assets have been uploaded to cloudsmith.

This will not work with trigger release announcement as it can't
get the version from GITHUB_REF as it isn't available there.

This commit adds the ability to provide an optional environment
variable VERSION to the trigger-release-announcement step. If the
variable is set, the version will be taken from that rather than
trying to parse it out of GITHUB_REF.

Closes #22
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Aug 29, 2020
@SeanTAllen SeanTAllen requested review from EpicEric and Theodus August 29, 2020 00:20
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 23.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen force-pushed the seantallen/22 branch 3 times, most recently from db174e7 to 9402755 Compare August 29, 2020 00:32
Copy link
Contributor

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeanTAllen SeanTAllen merged commit 13573a6 into master Aug 30, 2020
@SeanTAllen SeanTAllen deleted the seantallen/22 branch August 30, 2020 12:36
github-actions bot pushed a commit that referenced this pull request Aug 30, 2020
github-actions bot pushed a commit that referenced this pull request Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for overriding how trigger release announcement step gets version information
3 participants