Add support for ponyc's specialized build requirements #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We build ponyc in CirrusCI, not GitHub actions. We do this because we often need to build LLVM from source and GitHub doesn't provide execution environments that are powerful enough. This results in a change where we can't use a stock release-bot `trigger-release-announcement` command. When the ponyc workflow goes to trigger release announcements, the tag used to build isn't available so the version needs to be provided via the `CUSTOM_VERSION` environment variable that is added in this change. This functionality should have been included in 0.6.0 but was missed.
SeanTAllen
added
changelog - changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build ponyc in CirrusCI, not GitHub actions. We do this because we
often need to build LLVM from source and GitHub doesn't provide execution
environments that are powerful enough. This results in a change where we
can't use a stock release-bot
trigger-release-announcementcommand.When the ponyc workflow goes to trigger release announcements, the tag
used to build isn't available so the version needs to be provided via the
CUSTOM_VERSIONenvironment variable that is added in this change.This functionality should have been included in 0.6.0 but was missed.