Allow creating a Buffer
with no FontSystem
#127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This introduces a new constructor
Buffer::new_empty
which has zeroBufferLine
s and is unshaped.Buffer::new
callsBuffer::new_empty
.Context
#97 untangled the
Buffer
from theFontSystem
, but didn't remove the need to pass aFontSystem
intoBuffer::new
.It is useful to be able to initialise a
Buffer
when you don't have aFontSystem
in scope, for example if you want toimpl Default
for some type that contains aBuffer
, since it is otherwise constructable without aFontSystem
:Future work
Any of the examples where
Buffer::new
is called and then immediately overwritten throughBuffer::set_text
or overwriting theBufferLine
s could be rewritten in terms ofBuffer::new_empty
but I have not done this.