Only install --recommended drivers #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidmhewitt If I remember correctly, you have non-Nvidia drivers that you install using ubuntu-drivers, does my patch affect this? |
|
Can confirm that the |
jackpot51
approved these changes
Aug 30, 2023
|
One more review would be very appreciated 🙏 The current code will try to install all the Nvidia drivers at once, resulting in a non-working system (at least for me) that cannot be fixed by simply installing the right driver version later. |
jacobgkau
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from here elementary/os#686 (comment)
ubuntu-drivers listreturns a list of 9 Nvidia drivers in Ubuntu 22.04 and elementary OS 7. However, we only want to install one of them. With--recommended, only the most recent driver will be listed.Committed from the GitHub web UI, I don't have a development environment for this right now.