Skip to content

Commit

Permalink
firmware: arm_ffa: Remove incorrect assignment of driver_data
Browse files Browse the repository at this point in the history
The ffa core driver currently assigns its own driver information
to individual ffa device driver_data which is wrong. Firstly, it leaks
this core driver information to individual ffa_device and hence to
ffa_driver. Secondly the ffa_device driver_data is for use by individual
ffa_driver and not for this core driver managing all those devices.

Link: https://lore.kernel.org/r/[email protected]
Fixes: d0c0bce ("firmware: arm_ffa: Setup in-kernel users of FFA partitions")
Signed-off-by: Sudeep Holla <[email protected]>
  • Loading branch information
sudeep-holla committed Apr 29, 2022
1 parent f3c45c0 commit 00512d2
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/firmware/arm_ffa/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -694,8 +694,6 @@ static void ffa_setup_partitions(void)
__func__, tpbuf->id);
continue;
}

ffa_dev_set_drvdata(ffa_dev, drv_info);
}
kfree(pbuf);
}
Expand Down

0 comments on commit 00512d2

Please sign in to comment.