Skip to content

Commit

Permalink
gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe
Browse files Browse the repository at this point in the history
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 76c47d1 ("gpio: mpc8xxx: Add ACPI support")
Signed-off-by: Miaoqian Lin <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
Signed-off-by: Bartosz Golaszewski <[email protected]>
  • Loading branch information
Yuuoniy authored and brgl committed Jan 17, 2022
1 parent df0cc57 commit 0b39536
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpio/gpio-mpc8xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform_device *pdev)
}

mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
if (!mpc8xxx_gc->irqn)
return 0;
if (mpc8xxx_gc->irqn < 0)
return mpc8xxx_gc->irqn;

mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
MPC8XXX_GPIO_PINS,
Expand Down

0 comments on commit 0b39536

Please sign in to comment.