-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for directory change in warp/iterm2 environments #68
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe recent update enhances the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- lib/command/add.js (1 hunks)
- lib/command/find.js (1 hunks)
- lib/utils.js (1 hunks)
- package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- package.json
Additional comments not posted (5)
lib/utils.js (3)
14-18
: Add Warp terminal support togenerateAppleScript
.The added script for the Warp terminal is consistent with the existing scripts for Terminal and iTerm. The logic appears correct.
24-24
: Update the return statement to include Warp terminal support.The return statement correctly includes the Warp terminal script, ensuring the appropriate script is executed based on the current terminal application.
27-32
: Add new functiongenerateWarpScript
.The function correctly generates a script for the Warp terminal, consistent with the existing script generation functions.
lib/command/add.js (1)
35-39
: Add support for Warp terminal inAddCommand
.The added logic correctly checks for the Warp terminal and generates the appropriate script. The code is consistent with the existing logic for the Darwin platform.
lib/command/find.js (1)
39-43
: Add support for Warp terminal inFindCommand
.The added logic correctly checks for the Warp terminal and generates the appropriate script. The code is consistent with the existing logic for the Darwin platform.
Related to #64
Implements support for automatically switching to the corresponding directory in warp/iterm2 environments after adding a project, and updates the version number.
generateWarpScript
inlib/utils.js
to generate a script for changing directories in warp/iterm2 environments.generateAppleScript
inlib/utils.js
to include support for warp/iterm2 environments by adding awarpCommand
script and updating the return statement to execute the appropriate script based on the current terminal application.lib/command/add.js
andlib/command/find.js
to support changing directories in warp/iterm2 environments by utilizing the updatedgenerateAppleScript
function. Additionally, introduces a check for theTERM_PROGRAM
environment variable to determine if the terminal is Warp and uses thegenerateWarpScript
function accordingly.package.json
to 2.2.0 to reflect the new feature addition.For more details, open the Copilot Workspace session.
Summary by CodeRabbit
New Features
Improvements
Version Update