Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 0.1.2. #553

Merged
merged 1 commit into from
May 29, 2020

Conversation

jeromekelleher
Copy link
Member

Closes #551

I'll release tomorrow assuming there's no hiccups.

@jeromekelleher
Copy link
Member Author

Quite a lot in here, so it would be good to get some eyes on the changelog to make sure I didn't miss anything (apologies if I did!)

We should get into the habit of updating the changelog as we go from here I think - it's quite error prone (not to mention tedious) going back through the PR list.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #553 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          22       22           
  Lines        1949     1949           
  Branches      202      202           
=======================================
  Hits         1943     1943           
  Misses          2        2           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2381787...212b022. Read the comment docs.

@grahamgower
Copy link
Member

The PonAbe addition seems to be missing. Also, perhaps we could have separate headings for "new species", "new demographic models", and "new features"?

@jeromekelleher
Copy link
Member Author

The PonAbe addition seems to be missing. Also, perhaps we could have separate headings for "new species", "new demographic models", and "new features"?

Good call on both counts, should be fixed now.

Copy link
Member

@grahamgower grahamgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the git log as well, and this LGTM!

@ndukler
Copy link
Contributor

ndukler commented May 28, 2020

Dunno if we mention it because it's internal but we also added a QC check for sampling times in PR #429

@ndukler
Copy link
Contributor

ndukler commented May 28, 2020

Also I noticed that generation time was set to 1 for generics as per #459 although this was largely for the SLiM engine so again I don't know it it should be added

@agladstein
Copy link
Contributor

What belongs in a changelog? Because I'm seeing a lot of little commits that don't seem to fit into what you have already in the changelog.

@jeromekelleher
Copy link
Member Author

What belongs in a changelog? Because I'm seeing a lot of little commits that don't seem to fit into what you have already in the changelog.

I think a changelog should contain the things that a user needs to know about that are different to the last release. So, all the stuff that happened on the slim engine isn't relevant because it didn't exist in the last release. It's a quick summary that a user can look at and know (a) is there cool new stuff that I should be using and (b) is this release going to break my code.

@jeromekelleher
Copy link
Member Author

Dunno if we mention it because it's internal but we also added a QC check for sampling times in PR #429

This is more internal development infrastructure to me @ndukler, and not something that an end-user needs to know about.

@jeromekelleher jeromekelleher merged commit f6c583d into popsim-consortium:master May 29, 2020
@jeromekelleher jeromekelleher deleted the changelog-0.1.2 branch May 29, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write changelog
4 participants