-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for 0.1.2. #553
Changelog for 0.1.2. #553
Conversation
Quite a lot in here, so it would be good to get some eyes on the changelog to make sure I didn't miss anything (apologies if I did!) We should get into the habit of updating the changelog as we go from here I think - it's quite error prone (not to mention tedious) going back through the PR list. |
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 22 22
Lines 1949 1949
Branches 202 202
=======================================
Hits 1943 1943
Misses 2 2
Partials 4 4 Continue to review full report at Codecov.
|
d17ef54
to
645dc3c
Compare
The PonAbe addition seems to be missing. Also, perhaps we could have separate headings for "new species", "new demographic models", and "new features"? |
Good call on both counts, should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the git log as well, and this LGTM!
Dunno if we mention it because it's internal but we also added a QC check for sampling times in PR #429 |
Also I noticed that generation time was set to 1 for generics as per #459 although this was largely for the SLiM engine so again I don't know it it should be added |
What belongs in a changelog? Because I'm seeing a lot of little commits that don't seem to fit into what you have already in the changelog. |
I think a changelog should contain the things that a user needs to know about that are different to the last release. So, all the stuff that happened on the slim engine isn't relevant because it didn't exist in the last release. It's a quick summary that a user can look at and know (a) is there cool new stuff that I should be using and (b) is this release going to break my code. |
eaeb829
to
212b022
Compare
Closes #551
I'll release tomorrow assuming there's no hiccups.