Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration][ADO] Sync members once from a team #1355

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[Integration][ADO] Sync members once from a team #1355

wants to merge 9 commits into from
+133 −33

Conversation

shariff-6
Copy link
Contributor

Description

What -
Refactor handling of team members in Azure DevOps integration, fixing bug causing multiple syncs.

Why -
To resolve unnecessary data duplication and performance lapse caused by syncing team members multiple times.

How -

  • Refactored team member fetching and syncing logic.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

ADOTEAM
ADOMEMBER

API Documentation

Provide links to the API documentation used for this integration.

@shariff-6
feat(azure-devops): refactor team member handling
1460470 
- Add dedicated methods for team member operations
- Update member fetching to use graph/users endpoint
- Add team selector for member inclusion
- Update tests to match new implementation
@shariff-6
Merge branch 'main' of https://github.com/port-labs/ocean into PORT-1…
42b27cb 
…2649-Sync-Members-Once-From-a-Team
@shariff-6
Updates version
caed6e6
@shariff-6
Fixes lint
ee670f4
@shariff-6 shariff-6 requested a review from a team as a code owner January 27, 2025 11:35
@shariff-6 shariff-6 changed the title Port 12649 sync members once from a team [Integration][ADO] Sync members once from a team Jan 27, 2025
@shariff-6
Removes params from url definition
25ed9e0
@shariff-6
Adds test assertion to get team memebrs
2abbc80
@shariff-6
Adds logs
f4c06fb
@shariff-6
refactor: reorganize Azure DevOps team and user syncing
eeb860d 
- Split team syncing into two separate kinds:
 - `team`: Basic team information only
 - `team-with-members`: Teams enriched with member data
- Rename `generate_members` to `generate_users` for clarity
- Add new `Kind.USER` and `Kind.TEAMWITHMEMBER` enums
- Remove member enrichment logic from `resync_teams`
- Add dedicated `resync_team_with_members` handler
- Add `resync_users` handler for user syncing
@shariff-6
Merge branch 'main' of https://github.com/port-labs/ocean into PORT-1…
56eecf8 
…2649-Sync-Members-Once-From-a-Team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shariff-6