Add support for search identifier #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
Aug 21, 2024
| @@ -58,7 +58,7 @@ async def upsert_entity( | |||
| ) | |||
| handle_status_code(response, should_raise) | |||
| result = response.json() | |||
| result_entity = Entity.parse_obj(result) | |||
| result_entity = Entity.parse_obj(result.get("entity", {})) | |||
There was a problem hiding this comment.
is it a bug fix? as until now we didn't passed the "entity" key?
Comment on lines
157
to
158
| if not isinstance(resource.port.entity.mappings.identifier, str): | ||
| logger.info("Skip unregistering due to non string identifier mapping") |
There was a problem hiding this comment.
missing additional context for who this will be skipped ( which resource kind ).
and what would be the effect?
| # Set the results of the search relation and identifier to the entity | ||
| entity.identifier = result_entity.identifier or entity.identifier | ||
| if isinstance(entity.identifier, dict): |
There was a problem hiding this comment.
lets have a method inside of the entity class for knowing if its of type search identifier
omby8888
reviewed
Aug 28, 2024
port_ocean/core/models.py
Outdated
| @@ -19,6 +19,10 @@ class Entity(BaseModel): | |||
| properties: dict[str, Any] = {} | |||
| relations: dict[str, Any] = {} | |||
|
|
|||
| @property | |||
| def is_search_identifier(self) -> bool: | |||
There was a problem hiding this comment.
Suggested change
| def is_search_identifier(self) -> bool: | |
| def is_using_search_identifier(self) -> bool: |
omby8888
reviewed
Aug 28, 2024
| relations: dict[str, str | IngestSearchQuery] = Field(default_factory=dict) | ||
|
|
||
| @property | ||
| def is_search_identifier(self) -> bool: |
There was a problem hiding this comment.
Suggested change
| def is_search_identifier(self) -> bool: | |
| def is_using_search_identifier(self) -> bool: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Add support for search identifier
Why - New feature to allow updating an entity without knowing its identifier
How - Call upsert entity API with query, and allow it in mapping
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.