Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACM Cert Handler #20

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add ACM Cert Handler #20

merged 2 commits into from
Oct 26, 2023

Conversation

s33dunda
Copy link
Contributor

I did my best to adhere to the previously established patterns

Copy link
Contributor

@talsabagport talsabagport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🚀 I left some comments to address

lambda_function/aws/resources/acm_cert_handler.py Outdated Show resolved Hide resolved
lambda_function/aws/resources/acm_cert_handler.py Outdated Show resolved Hide resolved
lambda_function/aws/resources/acm_cert_handler.py Outdated Show resolved Hide resolved
- Use the NextToken Pattern
- allow list_parameters to allow other filters
- add log for list with current region
- add next_token self._cleanup_regions
@talsabagport talsabagport merged commit 9be2fe6 into port-labs:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants