Optional sha512 to spread out the final password for rand_pw app #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxkmm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
space usage:
the new added lib only use STL libs that other inner app codes already used, so no more spaces were taken.
before change:
Space remaining in flash ROM: 7664 bytes ( 0.7 %)after change:
Space remaining in flash ROM: 7664 bytes ( 0.7 %)outside code
lib is from https://github.com/ulwanski/sha512
safety
the sha-512 is predictable if you know previous code (the one that generated after rolling). but if you don't know the previous code, it would be hard to predict. So this change is safer