-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the opt_table_font()
method
#272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. PR #260 is ready for a re-review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 86.44% 86.45% +0.01%
==========================================
Files 42 42
Lines 4654 4689 +35
==========================================
+ Hits 4023 4054 +31
- Misses 631 635 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I added two quick comments on code tweaks, but feel free to push back on anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this beautiful PR -- I added a couple small suggestions. If they sound okay, feel free to merge after changing (or punt the suggestions and merge :)
I've incorporated your suggestions in two commits. If CI passes I'll merge this PR. Thanks! |
This adds the
opt_table_font()
method, which can be used for the easy addition of fonts (or a font stack) to the table. Here's an example where a font stack was used:Here's another example where a single font name is prepended to the list of default fonts:
Fixes: #175