fix: better error for list data fmt_nanoplot

[marcozzxx810]

Summary

add a type check for data column, so that only scalar value is passed.

will add a pytest but want to make sure this is expected.

Related GitHub Issues and PRs

• Ref: fmt_nanoplot invalid plot_type="bars" does not error, produces no plot #331

Checklist

• I understand and agree to the Code of Conduct.
• I have followed the Style Guide for Python Code as best as possible for the submitted code.
• I have added pytest unit tests for any new functionality.

[machow]

Hey, thanks for taking this up! It seems like the challenge in #331 might be:

• fmt_nanoplot current accepts two plot types: line, bar
• these types work with scalars. E.g. bar produces a single sideways bar.
• however, invalid plot_types seem to be allowed through. For examples bars (or maybe even barsabcdefg) don't raise an error :/.

I wonder if just validating that plot_type is in the list of plot_type options would be enough to resolve the issue? I'm happy to take it up, or if you want to take a swing at it, I'm happy to review!

[marcozzxx810]

Hi @machow , thank you for the guidelines. I think it is clear for me now.

I will change it and add a testcase for it

[marcozzxx810]

Hi @machow, I have updated the code but CI Test seems to failed in main as well.

It will be great that if you can let me know how to resolve.

[rich-iannone]

I can reproduce this on my system after upgrading Polars to version 0.20.28.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (e3649d2) to head (2bbbd1a).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   85.90%   85.91%           
=======================================
  Files          41       41           
  Lines        4328     4330    +2     
=======================================
+ Hits         3718     3720    +2     
  Misses        610      610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[machow]

This looks great, thanks so much for submitting this PR! These kinds of warnings seem really important for avoiding surprising issues due to typos. This LGTM -- Rich do you want to merge?