Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance cols_*() functions #366

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

jrycw
Copy link
Collaborator

@jrycw jrycw commented May 26, 2024

This PR aims to enhance the cols_*() functions by:

  • Abstracting the validation of sel_cols into a separate function and adding related tests.
  • Suggesting renaming vars to col_vars in the function. While vars might be acceptable in the function signature, it’s better to avoid using vars as a temporary variable name if possible.
  • Updating the syntax for constructing the DataFrame in the cols_*() test functions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (e3649d2) to head (642cf2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   85.90%   86.06%   +0.16%     
==========================================
  Files          41       41              
  Lines        4328     4321       -7     
==========================================
+ Hits         3718     3719       +1     
+ Misses        610      602       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow machow self-requested a review May 29, 2024 20:00
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@machow machow merged commit 2aad8f5 into posit-dev:main May 29, 2024
11 checks passed
@jrycw jrycw deleted the improve-cols-funcs branch May 29, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants