-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Allow spanners to use units notation in .tab_spanner()
#393
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 86.48% 86.43% -0.06%
==========================================
Files 42 42
Lines 4685 4696 +11
==========================================
+ Hits 4052 4059 +7
- Misses 633 637 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll open an issue to document this behavior in tab_spanner, but want to get this tucked away!
This PR allows for the use of units notation text in spanner labels (through
.tab_spanner()
). Here is an example of the intended usage: