Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: indicate that tab_spanner() allows for use of units notation in its label= arg #426

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

rich-iannone
Copy link
Member

This is a simple documentation improvement for the tab_spanner() method. The cols_label() allows for the use of units notation syntax and has documentation to explain that. This was missing for tab_spanner() though it has equivalent functionality. This PR explains that units notation can be used in tab_spanner()

Fixes: #395

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (0422164) to head (37772be).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   86.37%   86.68%   +0.31%     
==========================================
  Files          42       42              
  Lines        4681     4685       +4     
==========================================
+ Hits         4043     4061      +18     
+ Misses        638      624      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pr-426 August 30, 2024 17:39 Destroyed
@rich-iannone rich-iannone marked this pull request as ready for review September 9, 2024 18:03
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (from pairing, we'll add a guide page for better explaining text handling / units #439)

@rich-iannone rich-iannone merged commit 016c67f into main Sep 12, 2024
13 checks passed
@rich-iannone rich-iannone deleted the docs-tab-spanner-unit-syntax branch September 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document tab_spanner's unit syntax functionality
2 participants