Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: provide updates to PyCon- and SciPy-related blog posts #445

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

rich-iannone
Copy link
Member

This updates two blogposts focused on PyCon 2024 and SciPy 2024 events. Some dead/non-working links are updated here. Additional links to new resources (recorded videos) are provided here.

Fixes: #180

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (ea03bbc) to head (2ba634b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files          42       42           
  Lines        4702     4702           
=======================================
  Hits         4079     4079           
  Misses        623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pr-445 September 16, 2024 20:51 Destroyed
@github-actions github-actions bot temporarily deployed to pr-445 September 16, 2024 20:59 Destroyed
@github-actions github-actions bot temporarily deployed to pr-445 September 16, 2024 21:00 Destroyed
@machow machow marked this pull request as ready for review September 17, 2024 13:20
@@ -79,9 +79,10 @@ We’ll cover the following:

Check out these resources to learn more about the wild and beautiful life of display tables:

* [Great Tables example gallery](/docs/examples)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoot some of these broken links were my bad -- but it looks like the fixes may also be broken 😓.

Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the URL tweaks I suggest should fix the broken ones (which I introduced in the original blog post 😭 )

* [Great Tables example gallery](/docs/examples)
* [The Design Philosophy of Great Tables (blog post)](http://localhost:6877/blog/design-philosophy/)
* [Great Tables example gallery](../examples/index.html)
* [The Design Philosophy of Great Tables (blog post)](blog/design-philosophy/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [The Design Philosophy of Great Tables (blog post)](blog/design-philosophy/)
* [The Design Philosophy of Great Tables (blog post)](/blog/design-philosophy)

@@ -79,9 +79,10 @@ We’ll cover the following:

Check out these resources to learn more about the wild and beautiful life of display tables:

* [Great Tables example gallery](/docs/examples)
* [The Design Philosophy of Great Tables (blog post)](http://localhost:6877/blog/design-philosophy/)
* [Great Tables example gallery](../examples/index.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Great Tables example gallery](../examples/index.html)
* [Great Tables example gallery](/examples)

@rich-iannone
Copy link
Member Author

I didn't realize the suggestions were up here so I pretty much independently fixed up the links (and tested locally a few times while iterating). That said, things are looking functional now!

@machow machow merged commit 49ceeb7 into main Sep 17, 2024
13 checks passed
@rich-iannone rich-iannone deleted the docs-blog-formatters-science branch September 17, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog post on formatters for scientific reporting
2 participants