Favor OrderedSet().as_list()

[jrycw]

Related to #407.

It appears that both list(OrderedSet()) and unpacking OrderedSet() rely on the __iter__() method. I’d like to suggest using OrderedSet().as_list() instead of depending on the dunder method, as this approach is clearer and more stable, even though the implementation is unlikely to change.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (ea03bbc) to head (029ffb0).
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files          42       42           
  Lines        4702     4702           
=======================================
  Hits         4079     4079           
  Misses        623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[machow]

Seems reasonable, thanks for such a steady stream of improvements 😄

[machow]

@rich-iannone do you want to merge?