Update GT.save()
#454
Merged
Update GT.save()
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious why codecov bot isn't running for this PR? |
I looked into our project configuration in the codecov site and saw nothing that requires attention. This might be a rare miss from codecov (maybe due to services being down). I'll see if this can be reported to them however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #391, #440
This PR aims to refine
GT.save()in three areas:Path().suffixto check the file extension.window_sizedirectly instead of using indexing.encodingparameter, defaulting toutf-8for writing temporary files.I'm not entirely sure if
utf-8is the ideal fix for all users, but I believe it's the best default for most. Let's start withutf-8and adjust over time if needed.