-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add docstrings for new location methods #474
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 42 42
Lines 4838 4838
=======================================
Hits 4250 4250
Misses 588 588 ☔ View full report in Codecov by Sentry. |
Yooo this is looking so good!!!! This is a small thought -- I wonder if changing...
might help keep the index a bit punchier. The downside might be the word "location" doesn't get used, but it's in the section description, so may be okay 😬?! |
^^^ great idea and I made that change! |
Given that there are now 11 loc classes (new ones added through #341), we need to ensure that there is sufficient documentation for these (addressing #467). We need at least one example in each of their docstrings. And we have to ensure these are all added to the API reference.