Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix in headers causing their css classes get printed out #477

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

machow
Copy link
Collaborator

@machow machow commented Oct 1, 2024

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (d3305a2) to head (1de813d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          42       42           
  Lines        4838     4838           
=======================================
  Hits         4250     4250           
  Misses        588      588           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow
Copy link
Collaborator Author

machow commented Oct 1, 2024

Note that an additional effect of the quartodoc fix is that the offending section is also no long rendered in title case!

https://pr-477--gt-python.netlify.app/reference/gt.fmt_integer#adapting-output-to-a-specific-locale

image

@machow machow requested a review from rich-iannone October 1, 2024 18:15
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@machow machow merged commit 641a8d6 into main Oct 1, 2024
13 checks passed
@rich-iannone rich-iannone deleted the docs-fix-headers branch October 1, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants