Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use polars.__version__ in version check #505

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

lukemanley
Copy link
Contributor

Summary

Polars has a few different installations options including:

  • pip install polars
  • pip install polars-u64-idx
  • pip install polars-lts-cpu

The last one was not covered by the existing version check. This PR changes the version check to use polars.__version__ which should work for all installation types.

Related GitHub Issues and PRs

  • Ref: #

Checklist

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (5913c57) to head (f167bd0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   88.88%   88.91%   +0.02%     
==========================================
  Files          44       44              
  Lines        5216     5212       -4     
==========================================
- Hits         4636     4634       -2     
+ Misses        580      578       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow machow self-requested a review November 12, 2024 21:28
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict this is the right approach in this situation since in polars, many distribution names may correspond with the module polars. (and version() uses distribution name)

@rich-iannone rich-iannone merged commit 98d7b05 into posit-dev:main Nov 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants