feat: add fmt_icon() method
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 89.79% 89.79% -0.01%
==========================================
Files 45 45
Lines 5382 5431 +49
==========================================
+ Hits 4833 4877 +44
- Misses 549 554 +5 ☔ View full report in Codecov by Sentry. |
machow
reviewed
Nov 25, 2024
| elif isinstance(self.stroke_width, (int, float)): | ||
| stroke_width = f"{str(self.stroke_width)}px" | ||
| else: | ||
| stroke_width = self.stroke_width |
machow
reviewed
Nov 25, 2024
| if icon in self.fill_color: | ||
| fill_color = self.fill_color[icon] | ||
| else: | ||
| fill_color = None |
There was a problem hiding this comment.
Tests now present for this.
machow
requested changes
Nov 25, 2024
great_tables/_formats.py
Outdated
Comment on lines
3951
to
3967
| towny_mini = ( | ||
| pl.from_pandas(towny) | ||
| .select(["name", "csd_type", "population_2021"]) | ||
| .filter(pl.col("csd_type").is_in(["city", "town"])) | ||
| .group_by("csd_type", maintain_order=True) | ||
| .agg([ | ||
| pl.col("name").sort_by("population_2021", descending=True).head(5), | ||
| pl.col("population_2021").sort(descending=True).head(5) | ||
| ]) | ||
| .sort("csd_type") | ||
| .explode(["name", "population_2021"]) | ||
| .with_columns( | ||
| csd_type = pl.when(pl.col("csd_type") == "town") | ||
| .then(pl.lit("house-chimney")) | ||
| .otherwise(pl.lit("city")) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Is it possible to just select a few rows of this data. E.g. towny[[0, 3, 5], :]. Say maybe the top 2 in each of your groups. It seems easier to get into an example with less setup (a doesn't seem critical to have a comprehensive table).
There was a problem hiding this comment.
I took your approach and the setup for the example is far simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
fmt_icon()method. It depends on Font Awesome icons available in thefaiconslibrary, so that is a new dependency. Whenever that package is updated, new icons from the FA free set will be available. Here's an example of thefmt_icon()method in use: