Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize imports by converting absolute imports to relative imports #521

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

jrycw
Copy link
Collaborator

@jrycw jrycw commented Nov 24, 2024

This PR aims to ensure consistency by converting all absolute imports to relative imports across most of our modules, as the majority already use relative imports. However, for the _data_color folder, I felt it was more natural to retain absolute imports, so those have been left unchanged.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.70%. Comparing base (4771178) to head (8014ef0).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
great_tables/_utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   89.71%   89.70%   -0.01%     
==========================================
  Files          45       45              
  Lines        5202     5198       -4     
==========================================
- Hits         4667     4663       -4     
  Misses        535      535              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@rich-iannone rich-iannone merged commit 549b89e into posit-dev:main Dec 9, 2024
14 checks passed
@jrycw jrycw deleted the clean-import branch December 10, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants