Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add text about Pandas req for use of datasets #549

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

rich-iannone
Copy link
Member

This addresses a pyOpenSci reviewer comment. In the API reference section of the docs site, there is a note about a requirement for a Pandas installation when using any of the datasets from the datasets module.

Fixes: #529

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (925fa41) to head (19e9b2b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          45       45           
  Lines        5321     5321           
=======================================
  Hits         4778     4778           
  Misses        543      543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit 98f121f into main Dec 3, 2024
13 of 14 checks passed
@rich-iannone rich-iannone deleted the docs-note-pandas-req-datasets branch December 3, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pyOpenSci review] Add note about required use of Pandas for datasets
2 participants