Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix final step of Windows auto-update #6117

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

timtmok
Copy link
Contributor

@timtmok timtmok commented Jan 24, 2025

Release Notes

I've got a wiki update to describe the entire update process that is WIP: https://github.com/posit-dev/positron-wiki/tree/auto-updates

It describes the steps of the auto-update in detail for Windows that explains what the installer does to update Positron.

Add missing argument to inno_updater execution. It expects 3 arguments (exe path of existing installation, lock file status, and a string for the log). See https://github.com/microsoft/inno-updater/blob/3fc01e98dadd9b41fb8073f769fe0756a6f94cf9/src/main.rs#L546 (note that it does check for 4 but the first arg is inno_updater.exe)

Without the last argument, inno_updater.exe exits without replacing the existing install with the updated one.

New Features

  • N/A

Bug Fixes

QA Notes

This change is required so that the auto-update will complete successfully. Otherwise, the old installation will remain with the updated one located in the <existing Positron path>\_\ directory.

@timtmok timtmok requested a review from petetronic January 24, 2025 16:30
Copy link

github-actions bot commented Jan 24, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Add missing argument to inno_updater execution
@timtmok timtmok force-pushed the bugfix/5540-windows-inno-updater branch from 3a44d12 to b6f57fc Compare January 27, 2025 21:36
@timtmok timtmok merged commit 6ca1e8c into main Jan 28, 2025
8 checks passed
@timtmok timtmok deleted the bugfix/5540-windows-inno-updater branch January 28, 2025 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants