-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade repo to use Node 20 everywhere #1206
Comments
Thank you! I was hunting for an issue like when I made this one, turns out I was just ahead of the game a bit. |
Looks like microsoft/vscode#210467 (comment) was closed up. The upcoming release of VSCode may be on Electron 29. |
Let's find out what VSCode base the Positron beta will build from. |
Positron just built off of April 2024 (version 1.89). When they cut beta we can take a look. Great idea 👍 |
With the scripts updated to node 20, and the types updated this looks done. I did notice our tsconfig extension was still node18, and addressed that in #1813 |
Moving this back to in-progress, and to Beta 2. I noticed #1813 and some github workflows that were still using node-version 18. Will update those. The changelog doesn't need to be updated because this wasn't listed. |
Node 18 LTS active support ended in Oct 2023. However we still need to use Node 18 because Electron 28 (what VSCode uses) is still running Node 18.
When VSCode upgrades Electron to version 29 we can use Node 20 everywhere.
References
The text was updated successfully, but these errors were encountered: