Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tsconfig/node20 #1813

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Update to tsconfig/node20 #1813

merged 1 commit into from
Jun 24, 2024

Conversation

dotNomad
Copy link
Collaborator

@dotNomad dotNomad commented Jun 7, 2024

Updates our @tsconfig/node20 config extension in the homeview.

Intent

Related to #1206

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know how this affects our compatibility with earlier VSCode and Positron releases?

@dotNomad
Copy link
Collaborator Author

Do we know how this affects our compatibility with earlier VSCode and Positron releases?

Comparing the two configs (https://github.com/tsconfig/bases/blob/main/bases/node18.json vs https://github.com/tsconfig/bases/blob/main/bases/node20.json) it looks like all of the compiler options are the same, so I would suspect this doesn't affect our VSCode or Positron releases.

@dotNomad dotNomad merged commit ac8818b into main Jun 24, 2024
12 checks passed
@dotNomad dotNomad deleted the dotnomad/tsconfig-node20 branch June 24, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants