-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(integration): Coordinate tested assets versions #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
force-pushed
the
ci/test-latest-assets
branch
from
July 1, 2024 15:06
418061d
to
7159e31
Compare
…()` assets not the hard-coded default assets version
…ase shinylive assets Otherwise the locally-built and installed assets may have the same version number and may mask the released assets.
schloerke
reviewed
Jul 1, 2024
shell: Rscript {0} | ||
run: | | ||
shinylive_local_version <- shinylive:::package_json_version("shinylive_assets") | ||
shinylive::assets_remove(shinylive_local_version) | ||
shinylive::assets_install_copy("shinylive_assets") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the py-shinylive assets version here, but that would lead to confusing testing. Instead, a proper and reasonable solution would be to update py-shinylive to support --assets-version
in CLI to use different versions when exporting.
schloerke
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three big changes: