Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(integration): Coordinate tested assets versions #101

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

gadenbuie
Copy link
Contributor

@gadenbuie gadenbuie commented Jul 1, 2024

Three big changes:

  1. We now run the R package tests using the shinylive assets we built and installed in the previous steps (before we were building shinylive but testing with the default assets version).
  2. We now test r-shinylive in Quarto against the same version of shinylive as is used by py-shinylive. To do this, we needed to move the quarto integration test to happen immediately after installing the r-shinylive package, to ensure that we get the released shinylive assets. Later, we'll build and install the latest shinylive, which may have the same version number as the last release (but will be different).
  3. Finally, we also test r/py-shinylive together in Quarto using the latest, custom built shinylive.

@gadenbuie gadenbuie force-pushed the ci/test-latest-assets branch from 418061d to 7159e31 Compare July 1, 2024 15:06
@gadenbuie gadenbuie marked this pull request as ready for review July 1, 2024 15:19
…ase shinylive assets

Otherwise the locally-built and installed assets may have the same version number and may mask the released assets.
@gadenbuie gadenbuie requested a review from schloerke July 1, 2024 15:25
shell: Rscript {0}
run: |
shinylive_local_version <- shinylive:::package_json_version("shinylive_assets")
shinylive::assets_remove(shinylive_local_version)
shinylive::assets_install_copy("shinylive_assets")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the py-shinylive assets version here, but that would lead to confusing testing. Instead, a proper and reasonable solution would be to update py-shinylive to support --assets-version in CLI to use different versions when exporting.

@gadenbuie gadenbuie merged commit 5b1cebe into main Jul 1, 2024
12 checks passed
@gadenbuie gadenbuie deleted the ci/test-latest-assets branch July 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants