Restore short R version in r-wasm repo URLs #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Thanks @georgestagg! I have two small code style comments that I don't think are blocking but that would be nice to address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a previous version of webR, we required the full R version to be included as part of r-wasm repo URLs for Emscripten ABI compatability reasons. This was a temporary measure and is no longer required for the latest release of webR.
This PR restores the original short R versioning in repo.r-wasm.org URLs, matching the base R and r-universe behaviour.
The TODO mentioned combining two functions (one for r-wasm, the other for r-universe) but I've decided not to in case we diverge again in the future. Instead, I've just abstracted out the logic for showing a warning message when native and Wasm package versions don't match.
Fixes #110.