Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Preserve spaces in multi-part values. #203

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Preserve spaces in multi-part values. #203

merged 1 commit into from
Jan 7, 2020

Conversation

desandro
Copy link
Contributor

This commit fixes the bug with space separated values. Previously, 0 10px 20px 30px would be exported with commas: 0,10px,20px,30px. This commit preverses spaces, to export 0 10px 20px 30px as expected.

Hi! We use postcss-custom-properties a bunch here at @UrbanCompass ! Thank you for all your work on PostCSS!

I recently came across a bug using exportTo. Multi-part values like 0 10px 20px 30px would be exported with commas instead of spaces: 0,10px,20px,30px. Exported values would look even more wild if there were commas already. For example,

// original
border-color, background, box-shadow, color
// exported
border-color,,,background,,,box-shadow,,,color

This PR resolves that. Tests updated as well 😸

Preserve spaces in multi-part values.
889a93e 
This commit fixes the bug with space separated values. Previously, `0 10px 20px 30px` would be exported with commas: `0,10px,20px,30px`. This commit preverses spaces, to export `0 10px 20px 30px` as expected.
@jonathantneal jonathantneal merged commit 44dfb33 into postcss:master Jan 7, 2020
@desandro desandro mentioned this pull request Feb 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 6, 2020
Merged
@jsnajdr jsnajdr mentioned this pull request Jun 8, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathantneal jonathantneal jonathantneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desandro @jonathantneal