Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

feat: upgrade postcss-values-parser to version without high risk vulnererability #228

Merged
merged 1 commit into from
Sep 18, 2020
Merged

feat: upgrade postcss-values-parser to version without high risk vulnererability #228

merged 1 commit into from
Sep 18, 2020

Conversation

@davilima6
Copy link
Contributor Author

Tests fail for Node 8:

$ npm test
> [email protected] test /home/travis/build/postcss/postcss-custom-properties
> npm run test:js && npm run test:tape
> [email protected] test:js /home/travis/build/postcss/postcss-custom-properties
> eslint src/{*,**/*}.js --cache --ignore-path .gitignore --quiet
> [email protected] pretest:tape /home/travis/build/postcss/postcss-custom-properties
> rollup -c .rollup.js --silent
> [email protected] test:tape /home/travis/build/postcss/postcss-custom-properties
> postcss-tape
/home/travis/build/postcss/postcss-custom-properties/node_modules/is-url-superb/index.js:11
	} catch {
	        ^
SyntaxError: Unexpected token {
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:617:28)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/travis/build/postcss/postcss-custom-properties/node_modules/postcss-values-parser/lib/nodes/Word.js:12:15)
npm ERR! code ELIFECYCLE

Would you mind if we added package-lock.json ?

@Semigradsky
Copy link
Member

@davilima6 postcss-values-parser 4.x has breaking changes: Node v10+ now required

@Semigradsky Semigradsky added the MAJOR changes Major version update required label Sep 18, 2020
@davilima6
Copy link
Contributor Author

Would you mind dropping support for Node 8?

@Semigradsky
Copy link
Member

We will do it in next major version with Postcss 8 support

@davilima6
Copy link
Contributor Author

I see, so what is your suggestion for this PR/fix? Should it wait for such next major?

@Semigradsky Semigradsky merged commit b686923 into postcss:master Sep 18, 2020
@Semigradsky
Copy link
Member

Hm, I will publish new major version. Why not

@davilima6 davilima6 deleted the update-postcss-values-parser branch September 18, 2020 09:25
@Semigradsky
Copy link
Member

https://github.com/postcss/postcss-custom-properties/releases/tag/10.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
MAJOR changes Major version update required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants