Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re–use existing font-feature-settings declarations #1

Merged
merged 1 commit into from
Jan 27, 2015

Conversation

marek-saji
Copy link
Contributor

Declaration with:

selector
{
   font-variant-numeric: tabular-nums;
   font-variant-caps: all-small-caps;
}

Produced two font-feature-settings, first one being overwritten by first one:

selector
{
  font-feature-settings: "tnum"; /* has no effect */
  font-variant-numeric: tabular-nums;
  font-feature-settings: "smcp", "c2sc";
  font-variant-caps: all-small-caps;
}

Changed so that if rule already has a font-feature-settings (defined in source CSS or created by postcss for some previous font-variant-*), it gets reused.

@MoOx
Copy link
Contributor

MoOx commented Jan 23, 2015

Thanks for this awesome PR. I'll handle that really soon when checking if module need update for postcss 4.

MoOx added a commit that referenced this pull request Jan 27, 2015
Re–use existing font-feature-settings declarations
@MoOx MoOx merged commit ffaa147 into postcss:master Jan 27, 2015
@MoOx
Copy link
Contributor

MoOx commented Jan 27, 2015

Thanks a ton. Released as 1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants