fix: Preserve whitespace in certain HTML elements (#333)

postlight · Mar 19, 2019 · a250f40 · a250f40
1 parent 2a3ade7
commit a250f40
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/utils/text/fixtures/html.js b/src/utils/text/fixtures/html.js
@@ -610,6 +610,16 @@ const HTML = {
     `,
     after: 'What do you think?',
   },
+  normalizeSpacesPreserve: {
+    before: `
+      <div>
+        <p>What   do  you    think?</p>
+        <pre>  What     happens to        spaces?    </pre>
+      </div>
+    `,
+    after:
+      '<div> <p>What do you think?</p> <pre>  What     happens to        spaces?    </pre> </div>',
+  },
 
   // cleanHeaders
   cleanFirstHeds: {

diff --git a/src/utils/text/normalize-spaces.js b/src/utils/text/normalize-spaces.js
@@ -1,4 +1,4 @@
-const NORMALIZE_RE = /\s{2,}/g;
+const NORMALIZE_RE = /\s{2,}(?![^<>]*<\/(pre|code|textarea)>)/g;
 
 export default function normalizeSpaces(text) {
   return text.replace(NORMALIZE_RE, ' ').trim();

diff --git a/src/utils/text/normalize-spaces.test.js b/src/utils/text/normalize-spaces.test.js
@@ -16,4 +16,11 @@ describe('normalizeSpaces(text)', () => {
     );
     assert.equal(result, HTML.normalizeSpaces.after);
   });
+
+  it('preserves spaces in preformatted text blocks', () => {
+    const $ = cheerio.load(HTML.normalizeSpacesPreserve.before);
+
+    const result = normalizeSpaces($.html());
+    assert.equal(result, HTML.normalizeSpacesPreserve.after);
+  });
 });