Skip to content

Commit

Permalink
feat: people extractor (#70)
Browse files Browse the repository at this point in the history
No major problems!
  • Loading branch information
janetleekim authored and adampash committed Dec 22, 2016
1 parent 3cf2bb7 commit c06b19e
Show file tree
Hide file tree
Showing 4 changed files with 139 additions and 0 deletions.
6 changes: 6 additions & 0 deletions fixtures/people.com/1481580462922.html

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/extractors/custom/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ export * from './www.sbnation.com';
export * from './www.bloomberg.com';
export * from './www.bustle.com';
export * from './www.vox.com';
export * from './people.com';
45 changes: 45 additions & 0 deletions src/extractors/custom/people.com/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
export const PeopleComExtractor = {
domain: 'people.com',

title: {
selectors: [
['meta[name="og:title"]', 'value'],
],
},

author: {
selectors: [
'a.author.url.fn',
],
},

date_published: {
selectors: [
['meta[name="article:published_time"]', 'value'],
],
},

lead_image_url: {
selectors: [
['meta[name="og:image"]', 'value'],
],
},

content: {
selectors: [
'div.article-body__inner',
],

// Is there anything in the content you selected that needs transformed
// before it's consumable content? E.g., unusual lazy loaded images
transforms: {
},

// Is there anything that is in the result that shouldn't be?
// The clean selectors will remove anything that matches from
// the result
clean: [

],
},
};
87 changes: 87 additions & 0 deletions src/extractors/custom/people.com/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import assert from 'assert';
import fs from 'fs';
import URL from 'url';
import cheerio from 'cheerio';

import Mercury from 'mercury';
import getExtractor from 'extractors/get-extractor';
import { excerptContent } from 'utils/text';

describe('PeopleComExtractor', () => {
describe('initial test case', () => {
let result;
let url;
beforeAll(() => {
url =
'http://people.com/style/jennifer-aniston-coat-tags-jimmy-kimmel/';
const html =
fs.readFileSync('./fixtures/people.com/1481580462922.html');
result =
Mercury.parse(url, html, { fallback: false });
});

it('is selected properly', () => {
// This test should be passing by default.
// It sanity checks that the correct parser
// is being selected for URLs from this domain
const extractor = getExtractor(url);
assert.equal(extractor.domain, URL.parse(url).hostname);
});

it('returns the title', async () => {
// To pass this test, fill out the title selector
// in ./src/extractors/custom/people.com/index.js.
const { title } = await result;

// Update these values with the expected values from
// the article.
assert.equal(title, 'Jennifer Aniston on Leaving the Tags on Her Celine Coat: ‘I Wore It Four Times and Didn’t Notice!’');
});

it('returns the author', async () => {
// To pass this test, fill out the author selector
// in ./src/extractors/custom/people.com/index.js.
const { author } = await result;

// Update these values with the expected values from
// the article.
assert.equal(author, 'Emily Kirkpatrick');
});

it('returns the date_published', async () => {
// To pass this test, fill out the date_published selector
// in ./src/extractors/custom/people.com/index.js.
const { date_published } = await result;

// Update these values with the expected values from
// the article.
assert.equal(date_published, '2016-12-09T15:40:20.000Z');
});

it('returns the lead_image_url', async () => {
// To pass this test, fill out the lead_image_url selector
// in ./src/extractors/custom/people.com/index.js.
const { lead_image_url } = await result;

// Update these values with the expected values from
// the article.
assert.equal(lead_image_url, 'http://i2.wp.com/peopledotcom.files.wordpress.com/2016/12/jennifer-aniston5.jpg?crop=0px%2C0px%2C1500px%2C1125px&resize=660%2C495&ssl=1');
});

it('returns the content', async () => {
// To pass this test, fill out the content selector
// in ./src/extractors/custom/people.com/index.js.
// You may also want to make use of the clean and transform
// options.
const { content } = await result;

const $ = cheerio.load(content || '');

const first13 = excerptContent($('*').first().text(), 13);

// Update these values with the expected values from
// the article.
assert.equal(first13, 'People who don’t chronicle every item of clothing worn by the rich and');
});
});
});

0 comments on commit c06b19e

Please sign in to comment.