Feat: gothamist extractor #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev5873
reviewed
Mar 9, 2017
| 'div.image-left': 'figure', | ||
| '.image-left i': 'figcaption', | ||
| 'div.image-right': 'figure', | ||
| '.image-right i': 'figcaption', |
There was a problem hiding this comment.
I wonder if we can simplify the transform, but I'm not sure if we can.
|
I've made some updates to generalize some of the selectors. |
silasburton
commented
Mar 9, 2017
| @@ -11,7 +11,8 @@ export const GothamistComExtractor = { | |||
|
|
|||
| title: { | |||
| selectors: [ | |||
| '.entry-header h1', | |||
| 'h1', | |||
| 'h1.entry-header', | |||
There was a problem hiding this comment.
this should be .entry-header h1
There was a problem hiding this comment.
Hmm... ok that one should probably be left alone, there's another h1 on the page.
…er h1 on the page
kev5873
approved these changes
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.