Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for browser usage to parse current page #231

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

toufic-m
Copy link
Contributor

Add documentation that the URL parameter on Mercury.parse() is optional in a web browser, and would default to the current page

Copy link
Contributor

@george-haddad george-haddad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adampash adampash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@adampash adampash changed the title dx: Include instructions for browser usage to parse current page docs: Include instructions for browser usage to parse current page Jan 30, 2019
@adampash adampash changed the title docs: Include instructions for browser usage to parse current page docs: add instructions for browser usage to parse current page Jan 30, 2019
@adampash adampash merged commit 0668f5d into master Jan 30, 2019
@adampash adampash deleted the dx-usage-browser branch January 30, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants