feat: natgeo parser #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiffytoy
added
custom parser
needs-review
and removed
custom parser
needs-review
labels
dviramontes
force-pushed
the
feat-natgeo-extractor
branch
from
f82a6c2 to
408992a
Compare
Same as the news.nationalgeographic.com parser - for some reason the author name doesn’t appear to be getting pulled into the local copy of the file.
dviramontes
force-pushed
the
feat-natgeo-extractor
branch
from
12b1478 to
82c9101
Compare
kev5873
suggested changes
Feb 8, 2017
|
|
||
| title: { | ||
| selectors: [ | ||
| 'h1.main-title', |
There was a problem hiding this comment.
Generalize this h1?
'h1',
'h1.main-title',
|
|
||
| dek: { | ||
| selectors: [ | ||
| 'div.article__deck', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as the news.nationalgeographic.com parser - for some reason the
author name doesn’t appear to be getting pulled into the local copy of
the file.