-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infinite loop when optimizing #96
Comments
@rkaminsk Thanks for the report. The algorithm assumes that the final set of literals to minimize is ordered by decreasing weights but when writing the comparator for sparse weight lists, I failed to realize that missing levels might actually be relevant. That is, I missed that Anyhow, once the literals are ordered correctly, clasp computes the correct optimum. I'll try to push a fix in the next days. |
Since lexicographic optimization is working in most cases it could only be a nasty corner case. Always these pesky details. 😈 Thanks, for the quick investigation. |
* MinimizeBuilder::CmpWeight failed to handle missing levels correctly. In particular, if a tuple R with *negative* weight w at level p was compared to a tuple L with missing weight at p, RHS was incorrectly considered to be greater than L. Fix this so that now the weight at p is compared to 0 (no weight at p).
Thanks! |
The following program goes into an infinite loop when optimizing (always repeating the same suboptimal model):
The text was updated successfully, but these errors were encountered: